[java] UnnecessaryBooleanAssertion: Use InvocationMatcher to find assertions#6712
Merged
Conversation
Contributor
|
Compared to main: (comment created at 2026-05-27 04:32:04+00:00 for 5b7cddd) |
Member
|
Maybe that's the reason, the rule currently only matches by name? Do you have a specific problem where this check in it's current form causes problems? |
adangel
changed the title
adangel
changed the title
zbynek
force-pushed
the
assert-invocation-matcher
branch
3 times, most recently
from
a25e478 to
cb2bcc6
Compare
zbynek
force-pushed
the
assert-invocation-matcher
branch
from
cb2bcc6 to
5b7cddd
Compare
adangel
added a commit
that referenced
this pull request
May 28, 2026
adangel
added a commit
that referenced
this pull request
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Rule: UnnecessaryBooleanAssertion
Use more reliable detection of
assertTrue(true)andassertFalse(true)-- there's no reason this shoul be only checked in test classes, OTOH a method in a test class calledassertTrueis not necessarily one of the framework methods.Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)