Conversation
Contributor
|
Compared to main: (comment created at 2026-05-25 14:48:29+00:00 for 7d9ecce) |
UncleOwen
force-pushed
the
issue-4350-java]-ClassNamingConventions-testClassPattern-not-applied-to-class-that-inherits-all-its-@Test-methods
branch
2 times, most recently
from
1fd0d0f to
b6a2fe8
Compare
2 tasks
This change removes the visibility check from isJUnit4Method. It was not needed (see https://pull-requests.pmd-code.org/pr-6685/cbd30fcbbd68a7b96a9b4eabbbf1c46a46f7a411/regression/). This brings isJUnit4Method in line with isJUnit5Method and isTestNgMethod.
... by replacing its implementation with the obvious one. Slight change to the method signature of isTestClass. But that's allowed, since TestFrameworksUtil is NOT public API (it is in a .internal package)
UncleOwen
force-pushed
the
issue-4350-java]-ClassNamingConventions-testClassPattern-not-applied-to-class-that-inherits-all-its-@Test-methods
branch
from
b6a2fe8 to
1cb7b90
Compare
adangel
reviewed
May 25, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: Andreas Dangel <[email protected]>
UncleOwen
deleted the
issue-4350-java]-ClassNamingConventions-testClassPattern-not-applied-to-class-that-inherits-all-its-@Test-methods
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
TestFrameworksUtil.isJUnit4Method()and.isTestNgMethod()so that they can find tests in superclasses (JUnit 5/6 was already done in [java] Fix #3288: New rule JUnit5TestNoPrivateModifierRule #6604).isTestClass()to useisJunitXClass()andisTestNGClass()Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)