[test] Split up AbstractRuleSetFactoryTest.testAllPMDBuiltInRulesMeetConventions()#6646
Merged
adangel merged 8 commits intoMay 8, 2026
Conversation
…DBuiltInRulesMeetConventions
…RulesMeetConventions
…ltInRulesMeetConventions
…ltInRulesMeetConventions
Contributor
|
No relevant source code has been changed, pmdtester skipped. (comment created at 2026-05-08 13:29:03+00:00 for 27bcf21) |
adangel
force-pushed
the
split-up-testAllPMDBuiltInRulesMeetConventions
branch
from
fd3a44b to
27bcf21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Recently I got the following test failure:
... and because I didn't scroll right (nor down), I was like "err... what do you want to tell me?"
This PR breaks up the test into six separate tests. This way, you only get the message about what is actually wrong.
testAllPMDBuiltInRuleSetsAreSorted now checks RuleRefs, too.
Ready?
./mvnw clean verifypasses (checked automatically by github actions)