Skip to content

[java] OverridingThreadRun: Fix false negatives with other methods and anonymous classes#6636

Merged
adangel merged 5 commits into
pmd:mainfrom
zbynek:override
May 14, 2026
Merged

[java] OverridingThreadRun: Fix false negatives with other methods and anonymous classes#6636
adangel merged 5 commits into
pmd:mainfrom
zbynek:override

Conversation

@zbynek
Copy link
Copy Markdown
Contributor

@zbynek zbynek commented Apr 29, 2026 •
edited
Loading

Describe the PR

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@pmd-actions-helper
Copy link
Copy Markdown
Contributor

pmd-actions-helper Bot commented Apr 29, 2026 •
edited
Loading

Documentation Preview

Compared to main:
This changeset changes 0 violations,
introduces 44 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
There are 0 changed duplications, 0 new duplications and 0 removed duplications.
There are 0 changed CPD errors, 0 new CPD errors and 0 removed CPD errors.

Regression Tester Report

(comment created at 2026-05-08 19:46:31+00:00 for bc5b05c)

@zbynek zbynek marked this pull request as ready for review April 29, 2026 22:49
@zbynek zbynek force-pushed the override branch 2 times, most recently from 88af837 to 7a0e643 Compare April 29, 2026 22:50
@zbynek zbynek changed the title Fix XPath for OverridingThreadRun rule [java] Fix XPath for OverridingThreadRun rule Apr 29, 2026
adangel
adangel reviewed Apr 30, 2026
View reviewed changes
Comment thread pmd-java/src/main/resources/category/java/multithreading.xml Outdated
adangel
adangel reviewed Apr 30, 2026
View reviewed changes
Comment thread pmd-java/src/main/java/net/sourceforge/pmd/lang/java/types/TypeTestUtil.java
adangel
adangel reviewed Apr 30, 2026
View reviewed changes
Comment thread pmd-java/src/main/resources/category/java/multithreading.xml Outdated
zbynek and others added 3 commits April 30, 2026 22:03
@zbynek @adangel
Fix Java message format
50a98be 
Co-authored-by: Andreas Dangel <[email protected]>
@zbynek @adangel
Simplify XPath
e3874fe 
Co-authored-by: Andreas Dangel <[email protected]>
@zbynek
Add message test
274fd3b
@adangel adangel added the needs:user-input Maintainers are waiting for feedback from author label May 8, 2026
@zbynek zbynek requested a review from adangel May 13, 2026 22:48
@zbynek zbynek removed the needs:user-input Maintainers are waiting for feedback from author label May 13, 2026
@adangel adangel changed the title [java] Fix XPath for OverridingThreadRun rule [java] OverridingThreadRun: Fix false negatives with other methods and anonymous classes May 14, 2026
@adangel adangel added this to the 7.25.0 milestone May 14, 2026
@adangel adangel added the a:false-negative PMD doesn't flag a problematic piece of code label May 14, 2026
adangel
adangel approved these changes May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

adangel added a commit that referenced this pull request May 14, 2026
@adangel
[doc] Update release notes (#6636)
c0b42e8
adangel added a commit that referenced this pull request May 14, 2026
@adangel
[java] OverridingThreadRun: Fix false negatives with other methods an…
7b57d77 
…d anonymous classes (#6636)
@adangel adangel merged commit e361f4a into pmd:main May 14, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adangel adangel adangel approved these changes

Assignees

No one assigned

Labels

a:false-negative PMD doesn't flag a problematic piece of code

Projects

None yet

Milestone

7.25.0

Development

Successfully merging this pull request may close these issues.

2 participants

@zbynek @adangel