Skip to content

[java] Cleanup: Remove TODO from ModifierOwner.getVisibility()#6623

Merged
adangel merged 1 commit into
pmd:mainfrom
UncleOwen:remove-TODO-that-is-already-done
May 8, 2026
Merged

[java] Cleanup: Remove TODO from ModifierOwner.getVisibility()#6623
adangel merged 1 commit into
pmd:mainfrom
UncleOwen:remove-TODO-that-is-already-done

Conversation

@UncleOwen
Copy link
Copy Markdown
Member

Describe the PR

The thing that is TODO is already done.
It is getEffectiveVisibility() directly below.

Ready?

  • [n/a] Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • [n/a] Added (in-code) documentation (if needed)

The thing that is TODO is already done.
It is getEffectiveVisibility() directly below.
@pmd-actions-helper
Copy link
Copy Markdown
Contributor

Documentation Preview

Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
There are 0 changed duplications, 0 new duplications and 0 removed duplications.
There are 0 changed CPD errors, 0 new CPD errors and 0 removed CPD errors.

Regression Tester Report

(comment created at 2026-04-25 16:34:26+00:00 for 678f524)

@adangel adangel added the in:pmd-internals Affects PMD's internals label May 8, 2026
Copy link
Copy Markdown
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adangel adangel added this to the 7.25.0 milestone May 8, 2026
adangel added a commit that referenced this pull request May 8, 2026
@adangel adangel merged commit 52d6d9d into pmd:main May 8, 2026
13 checks passed
@UncleOwen UncleOwen deleted the remove-TODO-that-is-already-done branch May 8, 2026 11:15
@UncleOwen UncleOwen restored the remove-TODO-that-is-already-done branch May 8, 2026 13:18
@UncleOwen UncleOwen deleted the remove-TODO-that-is-already-done branch May 8, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in:pmd-internals Affects PMD's internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants