[java] Fix #3288: New rule JUnit5TestNoPrivateModifierRule#6604
Merged
adangel merged 13 commits intoMay 14, 2026
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 7 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes. Give us feedback
Contributor
|
Compared to main: (comment created at 2026-05-08 15:36:43+00:00 for 388a6bd) |
UncleOwen
changed the title
UncleOwen
force-pushed
the
issue-3288-new-rule-JUnitTestWrongModifier
branch
from
026eb3d to
3050e34
Compare
UncleOwen
force-pushed
the
issue-3288-new-rule-JUnitTestWrongModifier
branch
from
89dbe8e to
a806a83
Compare
UncleOwen
commented
Apr 25, 2026
UncleOwen
force-pushed
the
issue-3288-new-rule-JUnitTestWrongModifier
branch
from
77a57c9 to
efa374e
Compare
The round trip Node -> JTypeMirror -> Node doesn't work, if you end up in another source file.
UncleOwen
force-pushed
the
issue-3288-new-rule-JUnitTestWrongModifier
branch
from
efa374e to
571ecd8
Compare
adangel
changed the title
adangel
requested changes
May 7, 2026
Member
adangel
left a comment
adangel
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Please have a look at my comments.
adangel
added
the
needs:user-input
…rprone/JUnit5TestNoPrivateModifierRule.java Co-authored-by: Andreas Dangel <[email protected]>
adangel
removed
the
needs:user-input
adangel
added a commit
that referenced
this pull request
May 14, 2026
adangel
added a commit
that referenced
this pull request
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Flip side of JUnit5TestShouldBePackagePrivate - the existing rule checks that our junit5 tests aren't too visible, this new rule checks that they are visible enough. I didn't implement the (optional) JUnit4 part of the rule. Didn't feel like spending time on it, JUnit5 has been out for over 8 years.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)