[java] Fix #2801: Add a property to OnlyOneReturnRule to allow guard ifs#6587
Merged
adangel merged 4 commits intoMay 7, 2026
Conversation
UncleOwen
force-pushed
the
issue-2801-OnlyOneReturn-should-have-a-property-to-allow-early-exits
branch
from
35bf4e2 to
c87efc1
Compare
UncleOwen
force-pushed
the
issue-2801-OnlyOneReturn-should-have-a-property-to-allow-early-exits
branch
2 times, most recently
from
b133274 to
5c92282
Compare
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 11 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
UncleOwen
force-pushed
the
issue-2801-OnlyOneReturn-should-have-a-property-to-allow-early-exits
branch
2 times, most recently
from
3fdd066 to
f0b4e08
Compare
Contributor
|
Compared to main: (comment created at 2026-05-07 13:44:34+00:00 for 711a989) |
Member
Author
UncleOwen
force-pushed
the
issue-2801-OnlyOneReturn-should-have-a-property-to-allow-early-exits
branch
from
f0b4e08 to
ce6a230
Compare
Member
Author
|
I didn't look at all 3001 violations removed in the regression tester report, but I looked at some of them. Looks exactly like I thought it would look. |
UncleOwen
force-pushed
the
issue-2801-OnlyOneReturn-should-have-a-property-to-allow-early-exits
branch
from
ce6a230 to
ca5f4ff
Compare
UncleOwen
force-pushed
the
issue-2801-OnlyOneReturn-should-have-a-property-to-allow-early-exits
branch
from
ca5f4ff to
931c0ec
Compare
adangel
changed the title
adangel
approved these changes
May 7, 2026
adangel
added a commit
that referenced
this pull request
May 7, 2026
adangel
added a commit
that referenced
this pull request
May 7, 2026
UncleOwen
deleted the
issue-2801-OnlyOneReturn-should-have-a-property-to-allow-early-exits
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Add a new property to OnlyOneReturnRule called
allowGuardIfs. If that property is set to true, returns as part of guard ifs are ignored. A guard if is defined as an if statement, that isRelated issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)