[core] Avoid using getImage/@Image #4782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
adangel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
This refactors javascript, modelica, scala, vm and html to not rely anymore on getImage(), so that we can remove it in core.
For supporting the special case in html, I introduced two interfaces: TextNode and CommentNode.
Technically, this doesn't need to be part of 7.0.0, I was just curious what we would need to do, to get rid of getImage(). On the other side, merging this, then it would be done (at least for these languages).
Note: in html, I introduced some incompatibility (getText() now returns the normalized text - which was previously available through getNormalizedText(), and getWholeText() return the raw text - which was previously getText()).
Note 2: This PR is independent of #4777, but some minor merge conflicts will arise probably.
Note 3: Of course this creates breaking changes, since e.g.
@Imageno longer is available. If merged after 7.0.0, then this must be re-added as deprecated.Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)