[java] fix: remove delimiter attribute from ruleset category/java/errorprone.xml #4759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gory/java/errorprone.xml
When using `category/java/errorprone.xml` ruleset with PMD 7.0.0-rc4 I'm getting these warnings:
```
Warning at category/java/errorprone.xml:1039:78
1037| <properties>
1038| <property name="version" value="2.0"/>
1039| <property name="typesThatCompareByReference" type="List[String]" delimiter="," description="List of canonical type names for which reference comparison is allowed.">
^^^^^^^^^ Delimiter attribute is not supported anymore, values are always comma-separated.
1040| <value>java.lang.Enum,java.lang.Class</value>
1041| </property>
Warning at category/java/errorprone.xml:2353:62
2351| <priority>3</priority>
2352| <properties>
2353| <property name="annotations" type="List[String]" delimiter="," value="org.springframework.beans.factory.annotation.Autowired,javax.inject.Inject,com.google.inject.Inject" description="If a constructor is annotated with one of these annotations, then the class is ignored."/>
^^^^^^^^^ Delimiter attribute is not supported anymore, values are always comma-separated.
2354| <property name="xpath">
2355| <value>
```
Generated by 🚫 Danger |
adangel
changed the title
adangel
added a commit
that referenced
this pull request
Dec 7, 2023
adangel
added a commit
that referenced
this pull request
Dec 7, 2023
…nings [java] fix: remove delimiter attribute from ruleset category/java/errorprone.xml #4759
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
When using
category/java/errorprone.xmlruleset with PMD 7.0.0-rc4 I'm getting these warnings:Related issues
None.
Ready?
./mvnw clean verifypasses (checked automatically by github actions)