Make PMD buildable with java 21 #4699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes mockito be happy even with java21.
Generated by 🚫 Danger |
|
Apparently it is a older byte-buddy dependency. We use mockito 4.11.0, which uses byte-buddy 1.12.19. Updating this might also help. |
Yes, this works: byte-buddy 1.14.3 or newer supports Java 21. |
adangel
added a commit
that referenced
this pull request
Oct 19, 2023
adangel
added a commit
that referenced
this pull request
Oct 19, 2023
Make PMD buildable with java 21 #4699
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only change needed, so that PMD builds with java21. This seems to be a bug in mockito (see mockito/mockito#3121) but we seem to use this edge case only here. So I opted to go the simple way...
(mockito fails to call the default method
newListener()on interfaceRenderer).