@adangel should I create this rule also on a 6.XX version or the 7 is the only one used now ?
Have a good day !

Generated by 🚫 Danger

Hi @adangel @rsoesemann,

Just wanted to know if you could have a look on this PR ?

Have a good day !

Thanks for the PR!

I think we need a bit more test cases and improve the rule description a bit.

I think, the rule intention is logical IMHO - these method calls should always be used outside of the loop. However, I'm unsure about the real-world practical performance impact: The official apex documentation doesn't mention performance at all - and honestly, I would expect that e.g. Schema.getGlobalDescribes() is cached by the apex implementation anyways. Do you have any numbers for performance problems created by using these methods extensively (e.g. in a loop)? Otherwise it would just be an unproven claim and this rule might be better suited for "Best Practices"?

Hi @adangel,

You're right, this is not very documented how the usage of this method in loop affects the performance. This thread mention the performances issues and provides measures on it.

In fact, I had the idea of this rule while watching a demo of the Apex Guru (new functionality in Salesforce to provide insights on your implementation and identifying anti pattern usage)

Using this method in loops will be identified as anti-pattern by Apex Guru, so the idea was to be able to identify it before it arrives on the prod environment.

As far as I know Schema.getGlobalDescribes() is not cached and there is some custom framework to do so.

I have no problems with tagging this rule in Best practices section instead of performance, you have the final word ! 😄

@tprouvot Thanks for the pointers to stackexchange. Then I guess, we keep it in performance.