Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Doc: Fix references AutoClosable -> AutoCloseable #4665

Merged
merged 1 commit into from
Sep 8, 2023
Merged

[java] Doc: Fix references AutoClosable -> AutoCloseable #4665

merged 1 commit into from
Sep 8, 2023

Conversation

AndreyBozhko
Copy link
Contributor

@AndreyBozhko AndreyBozhko commented Sep 6, 2023

Describe the PR

I believe "closable" and "closeable" could be used interchangeably - however, the proper spelling for the Java interface is AutoCloseable.

This PR fixes docs and code snippets that refer/allude to the AutoCloseable interface.

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 7.0.0 milestone Sep 7, 2023
@adangel adangel added the in:documentation Affects the documentation label Sep 7, 2023
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost
Copy link

ghost commented Sep 7, 2023

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 13 errors and 7 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

@adangel adangel changed the title [doc] Fix references AutoClosable -> AutoCloseable [java] Doc: Fix references AutoClosable -> AutoCloseable Sep 8, 2023
adangel added a commit that referenced this pull request Sep 8, 2023
adangel added a commit that referenced this pull request Sep 8, 2023
[java] Doc: Fix references AutoClosable -> AutoCloseable #4665
@adangel adangel merged commit ba35bdc into pmd:master Sep 8, 2023
@AndreyBozhko AndreyBozhko deleted the autocloseable branch October 7, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:documentation Affects the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants