Use explicit encoding in ruleset xml files #4586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
jsotuyod
reviewed
Jun 1, 2023
| @@ -230,6 +231,36 @@ void testXmlSchema() throws Exception { | |||
| assertTrue(allValid, "All XML must parse without producing validation messages."); | |||
| } | |||
|
|
|||
| @Test | |||
| void verifyCorrectXmlEncoding() throws Exception { | |||
There was a problem hiding this comment.
rather than a test, this seems like something we can create a PMD rule for and have it enabled in our dogfooding.
There was a problem hiding this comment.
I've just realized that the XML declaration data in unobtainable from our AST, so this rule could not be implemented… so I extended our XML language and created the rule in #4592 :)
4 tasks
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Oct 19, 2023
adangel
added a commit
that referenced
this pull request
Oct 19, 2023
Use explicit encoding in ruleset xml files #4586
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Just a minor tweak I noticed recently. It's better to explicitly state the encoding, that is used. This avoids confusion.
This change also adds tests to ensure, that the encoding for the category ruleset files is UTF-8.
Ready?
./mvnw clean verifypasses (checked automatically by github actions)