[cpp] CPD: Added strings as literal and ignore identifiers in sequences #4470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
adangel
changed the title
adangel
added
in:cpd
adangel
approved these changes
May 19, 2023
There was a problem hiding this comment.
Thanks!
I'll update the docs (see https://docs.pmd-code.org/latest/pmd_userdocs_cpd.html#cli-options-reference) and also update the CPD GUI for this new option.
pmd-cli/src/main/java/net/sourceforge/pmd/cli/commands/internal/CpdCommand.java
Show resolved
Hide resolved
adangel
added a commit
to adangel/pmd
that referenced
this pull request
May 19, 2023
adangel
added a commit
that referenced
this pull request
May 19, 2023
[cpp] CPD: Added strings as literal and ignore identifiers in sequences #4470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
For C++, when using array initializers, often macros or constants are used. These represent literals or constants.
Therefore it is valid to ignore identifiers like is done for literals.
In addition, STRING was missing from the allowed tokens and was therefore added among the allowed literals.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)