Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assembly-plugin warnings #4460

Merged
merged 5 commits into from
May 28, 2023
Merged

Conversation

adangel
Copy link
Member

@adangel adangel commented Apr 6, 2023

Describe the PR

Don't override "finalName" anymore. This however changes the filenames of the generated binary distribution files.

This fixes the following warnings and make sure, we can build PMD when overriding these properties won't be possible anymore:

[INFO] --- assembly:3.4.2:single (build-bin-dist) @ pmd-dist ---
[WARNING] Parameter 'finalName' is read-only, must not be used in configuration
[INFO] Reading assembly descriptor: src/main/resources/assemblies/pmd-bin.xml
[INFO] Building zip: /home/runner/work/pmd/pmd/pmd-dist/target/pmd-bin-7.0.0-SNAPSHOT.zip
[INFO] 
[INFO] --- assembly:3.4.2:single (build-src-dist) @ pmd-dist ---
[WARNING] Parameter 'finalName' is read-only, must not be used in configuration
[INFO] Reading assembly descriptor: src/main/resources/assemblies/pmd-src.xml
[INFO] Building zip: /home/runner/work/pmd/pmd/pmd-dist/target/pmd-src-7.0.0-SNAPSHOT.zip

Note: this is a 💥 breaking change: As the filename is changed, you might need to update your download/extract scripts.

Therefore, this change impacts also pmd-github-action and the landing page pmd.github.io.

Note 2: I've changed the filename for the doc.zip the same way for consistency.

Note 3: The content inside the zip-files stays the same: We still provide a base directory called pmd-bin-<version>.

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

Don't override "finalName" anymore. This however changes the filenames of the generated binary distribution files.
@ghost
Copy link

ghost commented Apr 6, 2023

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
No regression tested rules have been changed.

Generated by 🚫 Danger

adangel added a commit to adangel/pmd-regression-tester that referenced this pull request May 26, 2023
@adangel adangel merged commit cf83a91 into pmd:master May 28, 2023
@adangel adangel deleted the fix-assembly-finalName branch May 28, 2023 09:04
adangel added a commit to pmd/build-tools that referenced this pull request Jun 1, 2023
adangel added a commit to adangel/pmd that referenced this pull request Jun 1, 2023
adangel added a commit to adangel/pmd that referenced this pull request Jun 1, 2023
Updates build-tools to 22-SNAPSHOT

Refs pmd#4460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant