Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coco] CPD: Coco support for code duplication detection #4431

Merged
merged 2 commits into from
May 19, 2023
Merged

[coco] CPD: Coco support for code duplication detection #4431

merged 2 commits into from
May 19, 2023

Conversation

wener-tiobe
Copy link
Contributor

@wener-tiobe wener-tiobe commented Mar 23, 2023 •
edited
Loading

Describe the PR

Added Coco support from https://cocotec.io/, a modern programming language designed specifically for building event-driven software.

Grammar by Dimitri van Heesch.

Related issues

  • Fixes #

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@wener-tiobe
Added Coco language
fa1c51c
@wener-tiobe
Delete .vscode directory
6c24e77 
remove accidentally checked in .vscode folder
@ghost
Copy link

ghost commented Mar 23, 2023

1 Message
📖 No regression tested rules have been changed.

Generated by 🚫 Danger

@adangel adangel added in:cpd Affects the copy-paste detector in:grammar About the grammar of a lexer or parser, eg, a parse/lex exception a:new-language Proposal to add a new PMD or CPD language to the main distribution labels Mar 30, 2023
@adangel adangel self-requested a review March 30, 2023 13:48
@adangel adangel changed the title Coco support for code duplication detection CPD: Coco support for code duplication detection Apr 4, 2023
adangel
adangel approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I wonder about the user base of this language. Unfortunately, this language seems to be closed source, so I guess there are not many users. But then again, we have a couple of (CPD-only) languages, that I doubt are used by many people.

I'll merge it nevertheless. Maybe we can move the cpd-only languages structure in the source code into a same folder, then it would be a bit easier to see at a glance, which languages are supported. But that's for later and definitely a separate PR.

@adangel adangel added this to the 7.0.0 milestone May 19, 2023
@adangel adangel changed the title CPD: Coco support for code duplication detection [coco] CPD: Coco support for code duplication detection May 19, 2023
@adangel adangel self-assigned this May 19, 2023
adangel added a commit to adangel/pmd that referenced this pull request May 19, 2023
@adangel
[doc] Update docs and release notes for Coco (pmd#4431)
7d6d8d7
adangel added a commit that referenced this pull request May 19, 2023
@adangel
Merge pull request #4431 from tiobe:master
23629f4 
[coco] CPD: Coco support for code duplication detection #4431
@adangel adangel merged commit 11c06fd into pmd:master May 19, 2023
@wener-tiobe
Copy link
Contributor Author

Thanks!

I wonder about the user base of this language. Unfortunately, this language seems to be closed source, so I guess there are not many users. But then again, we have a couple of (CPD-only) languages, that I doubt are used by many people.

I'll merge it nevertheless. Maybe we can move the cpd-only languages structure in the source code into a same folder, then it would be a bit easier to see at a glance, which languages are supported. But that's for later and definitely a separate PR.

Thanks for adopting this feature! Indeed, the user base may be limited, but please know large software companies are actually using this, resulting in thousands of users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees

@adangel adangel

Labels
a:new-language Proposal to add a new PMD or CPD language to the main distribution in:cpd Affects the copy-paste detector in:grammar About the grammar of a lexer or parser, eg, a parse/lex exception
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wener-tiobe @adangel