Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Fix NPE when only --file-list is specified #4423

Merged
merged 1 commit into from
Mar 23, 2023
Merged

[cli] Fix NPE when only --file-list is specified #4423

merged 1 commit into from
Mar 23, 2023

Conversation

adangel
Copy link
Member

@adangel adangel commented Mar 18, 2023

Describe the PR

This fixes the following NPE:

java.lang.NullPointerException
	at net.sourceforge.pmd.util.AssertionUtil.requireContainsNoNullValue(AssertionUtil.java:30)
	at net.sourceforge.pmd.PMDConfiguration.setInputPathList(PMDConfiguration.java:515)
	at net.sourceforge.pmd.cli.commands.internal.PmdCommand.toConfiguration(PmdCommand.java:278)
	at net.sourceforge.pmd.cli.commands.internal.PmdCommand.execute(PmdCommand.java:328)
	at net.sourceforge.pmd.cli.commands.internal.AbstractPmdSubcommand.call(AbstractPmdSubcommand.java:35)
	at net.sourceforge.pmd.cli.commands.internal.AbstractPmdSubcommand.call(AbstractPmdSubcommand.java:20)
	at picocli.CommandLine.executeUserObject(CommandLine.java:2041)
	at picocli.CommandLine.access$1500(CommandLine.java:148)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
	at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
	at picocli.CommandLine.execute(CommandLine.java:2170)
	at net.sourceforge.pmd.cli.PmdCli.main(PmdCli.java:18)

We use --file-list in the pmd-github-action and without this fix, it won't work...

@adangel adangel added the a:bug PMD crashes or fails to analyse a file. label Mar 18, 2023
@adangel adangel added this to the 7.0.0 milestone Mar 18, 2023
@ghost
Copy link

ghost commented Mar 18, 2023

1 Message
📖 No regression tested rules have been changed.

Generated by 🚫 Danger

@adangel adangel merged commit a93a94b into pmd:master Mar 23, 2023
@adangel adangel deleted the pmd7-cli-file-list branch March 23, 2023 09:23
@wener-tiobe
Copy link
Contributor

This issue still holds true for CPD.

@wener-tiobe
Copy link
Contributor

I'll create a PR to provide a fix

@wener-tiobe wener-tiobe mentioned this pull request Sep 6, 2023
Merged
4 tasks
adangel added a commit that referenced this pull request Sep 9, 2023
@adangel
[doc] Update release notes (#4423, #4664)
7076f16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
a:bug PMD crashes or fails to analyse a file.
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@adangel @wener-tiobe