Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Fix reported line number in CommentContentRule #4416

Merged
merged 2 commits into from
Mar 17, 2023
Merged

[java] Fix reported line number in CommentContentRule #4416

merged 2 commits into from
Mar 17, 2023

Conversation

oowekyala
Copy link
Member

Describe the PR

Fix a problem with line number not being incremented. Compare with #4369

Related issues

  • Fixes #

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added this to the 7.0.0 milestone Mar 11, 2023
@ghost
Copy link

ghost commented Mar 11, 2023 •
edited by ghost
Loading

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 13 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 13 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel changed the title Fix CommentContentRule [java] Fix reported line number in CommentContentRule Mar 17, 2023
adangel
adangel approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'll update the tests and simplify CommentSizeRule as well (no extra var "i" is needed)

adangel added a commit that referenced this pull request Mar 17, 2023
@adangel
[doc] Update release notes (#4416)
7e3c921
adangel added a commit that referenced this pull request Mar 17, 2023
@adangel
Merge pull request #4416 from oowekyala:clem.fix-comment-content
4ab91cb 
[java] Fix reported line number in CommentContentRule #4416
@adangel adangel merged commit 5096cab into pmd:master Mar 17, 2023
@oowekyala oowekyala deleted the clem.fix-comment-content branch May 13, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oowekyala @adangel