[julia] CPD: Add support for Julia code duplication #4403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oowekyala
reviewed
Feb 21, 2023
pmd-julia/src/test/resources/net/sourceforge/pmd/lang/julia/cpd/testdata/mathExample.txt
Outdated
Show resolved
Hide resolved
pmd-julia/src/main/antlr4/net/sourceforge/pmd/lang/julia/ast/Julia.g4
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,163 @@ | |||
| grammar Julia; | |||
There was a problem hiding this comment.
Did you create this grammar yourself? Have you taken a look at this one? It looks more complete, albeit unmaintained
There was a problem hiding this comment.
This grammar was made by Paul Jansen from TIOBE. In any case, I'll have a look at the grammar you suggested.
There was a problem hiding this comment.
We decided that it is indeed better to take your suggestion as a starting point. It will require some additional work though.
There was a problem hiding this comment.
I'd vote for using this grammar for now. We can change it always later on. Right now, it's only used for CPD/tokenization, so there should be no compatibility issues when we change the grammar later.
Replaced tab with spaces
Removed unneeded comments
Generated by 🚫 Danger |
Updated grammar. Updated unittest accordingly.
Removed reintroduced comments
adangel
added
a:new-language
adangel
changed the title
adangel
changed the title
oowekyala
approved these changes
Apr 29, 2023
oowekyala
changed the title
oowekyala
added a commit
that referenced
this pull request
Apr 29, 2023
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Added support for code duplication analysis on Julia code.
See https://julialang.org/ for more information on Julia
Related issues
None
Ready?
./mvnw clean verifypasses (checked automatically by github actions)