Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[javascript] CPD: add support for Typescript using antlr4 grammar #4402

Merged
merged 6 commits into from
Apr 28, 2023
Merged

[javascript] CPD: add support for Typescript using antlr4 grammar #4402

merged 6 commits into from
Apr 28, 2023

Conversation

pguyot
Copy link
Contributor

@pguyot pguyot commented Feb 20, 2023 •
edited
Loading

Describe the PR

Following T-SQL, add minimal CPD support for Typescript using antlr4 grammar from https://github.com/antlr/grammars-v4

Related issues

  • Fixes #

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@pguyot
Copy link
Contributor Author

pguyot commented Feb 20, 2023

TypescriptLexerBase, coming directly from antlr4 repository, doesn't pass checkstyle.
Please advise what would be the best approach.

oowekyala
oowekyala reviewed Feb 20, 2023
View reviewed changes
Copy link
Member

@oowekyala oowekyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I think it would be nice to put this all into the existing pmd-javascript module though.

@pguyot pguyot force-pushed the w08/add_support_for_typescript branch from c2e61bf to 5660d26 Compare February 23, 2023 10:44
@adangel adangel added a:new-language Proposal to add a new PMD or CPD language to the main distribution in:cpd Affects the copy-paste detector in:grammar About the grammar of a lexer or parser, eg, a parse/lex exception labels Apr 4, 2023
@ghost
Copy link

ghost commented Apr 4, 2023

1 Message
📖 No regression tested rules have been changed.

Generated by 🚫 Danger

@oowekyala oowekyala self-assigned this Apr 25, 2023
oowekyala
oowekyala approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@oowekyala oowekyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oowekyala oowekyala merged commit 5c5f94e into pmd:master Apr 28, 2023
@oowekyala oowekyala added this to the 7.0.0 milestone Apr 28, 2023
@oowekyala oowekyala changed the title CPD: add support for Typescript using antlr4 grammar [javascript] CPD: add support for Typescript using antlr4 grammar Apr 28, 2023
oowekyala added a commit that referenced this pull request Apr 28, 2023
@oowekyala
Update release notes, ref #4402
6d8ffa9
@pguyot pguyot deleted the w08/add_support_for_typescript branch April 29, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel left review comments

@oowekyala oowekyala oowekyala approved these changes

Assignees

@oowekyala oowekyala

Labels
a:new-language Proposal to add a new PMD or CPD language to the main distribution in:cpd Affects the copy-paste detector in:grammar About the grammar of a lexer or parser, eg, a parse/lex exception
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pguyot @adangel @oowekyala