Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Improve module grammar #3890

Merged
merged 7 commits into from
Apr 22, 2022
Merged

[java] Improve module grammar #3890

merged 7 commits into from
Apr 22, 2022

Conversation

oowekyala
Copy link
Member

I believe this is the last grammar change needed for PMD 7. We can proceed with cleaning up the AST as in #3831

Describe the PR

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

oowekyala added 2 commits April 1, 2022 19:06
@oowekyala
[java] Improve module grammar
bc19d2c 
Type names in "provides" directives are disambiguated
like any other type name.

ASTName is made redundant and removed for good.
@oowekyala
Add tests for module directives
b7c3e47
@oowekyala oowekyala added this to the 7.0.0 milestone Apr 1, 2022
@ghost
Copy link

ghost commented Apr 1, 2022 •
edited by ghost
Loading

2 Messages
📖 Compared to pmd/7.0.x:
This changeset changes 26 violations,
introduces 19 new violations, 0 new errors and 0 new configuration errors,
removes 18 violations, 0 errors and 0 configuration errors.
Full report
📖 Compared to master:
This changeset changes 56919 violations,
introduces 34985 new violations, 2 new errors and 0 new configuration errors,
removes 139312 violations, 25 errors and 6 configuration errors.
Full report

Generated by 🚫 Danger

@oowekyala oowekyala added the in:grammar About the grammar of a lexer or parser, eg, a parse/lex exception label Apr 6, 2022
@oowekyala oowekyala mentioned this pull request Apr 9, 2022
Closed
adangel
adangel reviewed Apr 12, 2022
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

I've added a new section in https://github.com/pmd/pmd/wiki/Java_clean_changes#module-declarations - updated already with ModuleUsesDirective using a ClassOrInterfaceType as child node instead of package name.

@adangel
Copy link
Member

adangel commented Apr 12, 2022

The regression tester is also not running properly:

 I, [2022-04-01T19:48:35.834774 #14483]  INFO -- : Autogenerating a dynamic ruleset based on source changes
  E, [2022-04-01T19:48:35.996017 #14483] ERROR -- : 
  E, [2022-04-01T19:48:35.996101 #14483] ERROR -- : fatal: bad revision 'master..HEAD'

seems like this is the same for the other PRs against pmd/7.0.x. I guess, we need to call it differently and use the autogenerated ruleset from the first run (when we compared against pmd7) because we don't have master checkout out (only pmd/7.0.x + PR).

@oowekyala
Copy link
Member Author

Thanks for updating the wiki and spotting that mistake about the uses directive!

@oowekyala oowekyala self-assigned this Apr 20, 2022
@adangel adangel merged commit 8f00641 into pmd:pmd/7.0.x Apr 22, 2022
@oowekyala oowekyala deleted the java-grammar-module branch April 22, 2022 08:04
@adangel adangel mentioned this pull request Jan 23, 2023
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees

@oowekyala oowekyala

Labels
in:grammar About the grammar of a lexer or parser, eg, a parse/lex exception
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oowekyala @adangel