Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] UnnecessaryBoxing - check for Integer.valueOf(String) calls #3500

Merged
merged 2 commits into from
Sep 17, 2021
Merged

[java] UnnecessaryBoxing - check for Integer.valueOf(String) calls #3500

merged 2 commits into from
Sep 17, 2021

Conversation

adangel
Copy link
Member

@adangel adangel commented Sep 10, 2021 •
edited
Loading

Rule: UnnecessaryBoxing

Describe the PR

This implements the last point of #2973

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 7.0.0 milestone Sep 10, 2021
@adangel adangel mentioned this pull request Sep 10, 2021
Closed
8 tasks
@ghost
Copy link

ghost commented Sep 10, 2021 •
edited by ghost
Loading

2 Messages
📖 Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 38 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
📖 Compared to master:
This changeset changes 31204 violations,
introduces 21190 new violations, 3 new errors and 0 new configuration errors,
removes 137925 violations, 8 errors and 3 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 38 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 31204 violations,
introduces 21190 new violations, 3 new errors and 0 new configuration errors,
removes 137925 violations, 8 errors and 3 configuration errors.
Full report

Generated by 🚫 Danger

oowekyala
oowekyala approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@oowekyala oowekyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks :)

@oowekyala oowekyala merged commit b511fa2 into pmd:pmd/7.0.x Sep 17, 2021
@adangel adangel deleted the pmd7-unnecessaryboxing-improvements branch September 23, 2021 17:23
@adangel adangel mentioned this pull request Jan 23, 2023
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oowekyala oowekyala oowekyala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@adangel @oowekyala