Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Flatten body declarations #2300

Merged
merged 8 commits into from
Mar 17, 2020
Merged

[java] Flatten body declarations #2300

merged 8 commits into from
Mar 17, 2020

Conversation

oowekyala
Copy link
Member

Removes ClassOrInterfaceBodyDeclaration and TypeDeclaration. These were unnecessary since #1875, since now they just have one child. Instead this adds a couple of marker interfaces implemented by eg FieldDeclaration, MethodDeclaration, etc.

AFAIK this the last PR altering the grammar.

@oowekyala oowekyala added the in:ast About the AST structure or API, the parsing step label Feb 19, 2020
@oowekyala oowekyala added this to the 7.0.0 milestone Feb 19, 2020
@ghost
Copy link

ghost commented Feb 19, 2020

1 Message
📖 No java rules are changed!

Generated by 🚫 Danger

@oowekyala oowekyala merged commit 9b720c8 into pmd:java-grammar Mar 17, 2020
@adangel
Copy link
Member

adangel commented Mar 24, 2020

Updated https://github.com/pmd/pmd/wiki/Java_clean_changes#flattened-body-declarations

@oowekyala oowekyala deleted the grammar-flatten-body-declarations branch March 25, 2020 02:24
@adangel adangel mentioned this pull request Jan 23, 2023
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in:ast About the AST structure or API, the parsing step
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oowekyala @adangel