-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] Grammar type expr #2039
Merged
Merged
[java] Grammar type expr #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since parentheses are flattened, any expression may be in any position (which is good tbh, the API is simpler, and the AST is uniform)
Generated by 🚫 Danger |
adangel
reviewed
Sep 29, 2019
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTAssignmentExpression.java
Outdated
Show resolved
Hide resolved
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTAssignmentExpression.java
Show resolved
Hide resolved
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTConstructorCall.java
Outdated
Show resolved
Hide resolved
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTExplicitConstructorInvocation.java
Outdated
Show resolved
Hide resolved
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTInfixExpression.java
Outdated
Show resolved
Hide resolved
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTInstanceOfExpression.java
Outdated
Show resolved
Hide resolved
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/AbstractJavaNode.java
Show resolved
Hide resolved
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/InternalInterfaces.java
Show resolved
Hide resolved
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/InternalInterfaces.java
Outdated
Show resolved
Hide resolved
* Don't abbreviate getLhs/getRhs * Make ExplicitConstructorInvocation implement QualifierOwner
Use AtLeastOneChild to remove nullability warnings.
adangel
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grammar changes
Introduce
TypeExpression
, a node type that wraps aType
node but is an ASTExpressioninstanceof
expressions as infix expressions (which they are, syntactically), and fix the weird inconsistency, thatinstanceof
is in the middle of the precedence hierarchy of infix operators, yet is not itself an ASTInfixExpression. Now it has its own constant in BinaryOp, and ASTInstanceOfExpression extends ASTInfixExpression (its XPath name isInfixExpression
too).getLhsType
,getLhsExpression
,getAmbiguousLhs
(which were inconsistently defined anyway).Cleanup inconsistencies in the API of many nodes
TBH ASTPrimaryExpression is not useful in the API since #1872, and we should probably scrap it entirely.