VariableCanBeInlined

Proposed Category: codestyle

Description:

Inline variables when they are immediately used to return or throw.

• https://sonarsource.github.io/rspec/#/rspec/S1488
• https://github.com/apache/maven/pull/2404/files#r2113612293
• https://docs.openrewrite.org/recipes/staticanalysis/inlinevariable
• Issue #16421: Local variables should not be declared and then immediately returned or thrown S1488 checkstyle/checkstyle#16488

Code Sample: This should include code, that should be flagged by the rule. If possible, the "correct" code
according to this new rule should also be demonstrated.

public long ComputeDurationInMilliseconds()
{
  long duration = (((hours * 60) + minutes) * 60 + seconds ) * 1000 ;
  return duration;
}

public void DoSomething()
{
  ApplicationException myException = new ApplicationException();
  throw myException;
}

Possible Properties:

• Should this rule be customizable via properties?