Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] CommentDefaultAccessModifier ignoredAnnotations should include "org.junit.jupiter.api.extension.RegisterExtension" by default #4273

Closed
koalalam opened this issue Dec 27, 2022 · 2 comments · Fixed by #4444
Closed

[java] CommentDefaultAccessModifier ignoredAnnotations should include "org.junit.jupiter.api.extension.RegisterExtension" by default #4273

koalalam opened this issue Dec 27, 2022 · 2 comments · Fixed by #4444
Labels
a:false-positive PMD flags a piece of code that is not problematic
Milestone
7.0.0

Comments

@koalalam
Copy link

Affects PMD Version:

6.52.0

Rule:

CommentDefaultAccessModifier

https://pmd.sourceforge.io/pmd-6.52.0/pmd_rules_java_codestyle.html#commentdefaultaccessmodifier

Description:

Code Sample demonstrating the issue:

import com.github.tomakehurst.wiremock.common.ConsoleNotifier;
import com.github.tomakehurst.wiremock.junit5.WireMockExtension;
import org.junit.jupiter.api.extension.RegisterExtension;

class SomeTest {

  @RegisterExtension
  static final WireMockExtension WIRE_MOCK_EXTENSION =
      WireMockExtension.newInstance()
          .options(wireMockConfig().dynamicPort().notifier(new ConsoleNotifier(true)))
          .build();
}

Expected outcome:

Default value of "ignoredAnnotations" should include "org.junit.jupiter.api.extension.RegisterExtension"
@koalalam koalalam added the a:false-positive PMD flags a piece of code that is not problematic label Dec 27, 2022
@jsotuyod jsotuyod added the good first issue A great starting point for new contributors label Dec 28, 2022
@jsotuyod jsotuyod changed the title CommentDefaultAccessModifier - "ignoredAnnotations" should include "org.junit.jupiter.api.extension.RegisterExtension" by default [java] CommentDefaultAccessModifier ignoredAnnotations should include "org.junit.jupiter.api.extension.RegisterExtension" by default Dec 28, 2022
@nirvikpatel
Copy link
Contributor

nirvikpatel commented Mar 30, 2023 •
edited
Loading

Can i pick up this issue @koalalam @jsotuyod ?

nirvikpatel added a commit to nirvikpatel/pmd that referenced this issue Mar 30, 2023
@nirvikpatel
pmd#4273:new AnnotationDescriptor Added
6d247e6
@adangel adangel mentioned this issue Mar 30, 2023
Merged
@adangel adangel removed the good first issue A great starting point for new contributors label Mar 30, 2023
nirvikpatel added a commit to nirvikpatel/pmd that referenced this issue Mar 30, 2023
@nirvikpatel
pmd#4273 : Test Case Added
d9c0e87
@adangel adangel added this to the 7.0.0 milestone Apr 3, 2023
@adangel
Copy link
Member

adangel commented Apr 3, 2023

See also #3859

adangel added a commit that referenced this issue Apr 3, 2023
@adangel
[doc] Update release notes (#4444, #4273)
e73b011
adangel added a commit that referenced this issue Apr 3, 2023
@adangel
[java] Update rule test description (#4273)
7ee28a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:false-positive PMD flags a piece of code that is not problematic
Projects
None yet
Milestone
7.0.0
4 participants
@jsotuyod @adangel @koalalam @nirvikpatel