Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Ambiguous reference error in valid code #3763

Closed
oowekyala opened this issue Feb 7, 2022 · 0 comments · Fixed by #3764
Closed

[java] Ambiguous reference error in valid code #3763

oowekyala opened this issue Feb 7, 2022 · 0 comments · Fixed by #3764
Labels
a:bug PMD crashes or fails to analyse a file. in:symbol-table Affects the symbol table code
Milestone
7.0.0

Comments

@oowekyala
Copy link
Member

oowekyala commented Feb 7, 2022 •
edited
Loading

Affects PMD Version: 7.0.0

Make sure, to test with the latest PMD version.

Description:

Java reference resolution reports an ambiguity error where there is none, when a statically imported type shadows a java.lang member.

See https://github.com/pmd/pmd/runs/5091674249?check_suite_focus=true#step:7:9523

Exception Stacktrace:

Reference 'Exception' is ambiguous, both net.sourceforge.pmd.renderers.internal.sarif.SarifLog.Exception and java.lang.Exception match

Code Sample demonstrating the issue:

Container.java

package p;
public class Container { 
  public static class Exception {}
}

Foo.java

import static p.Container.Exception;
public class Foo {
  static {
    Exception e; // should be unambiguously p.Container.Exception 
  }
}
at Foo.java: Reference 'Exception' is ambiguous, both p.Container.Exception and java.lang.Exception match
@oowekyala oowekyala added a:bug PMD crashes or fails to analyse a file. in:symbol-table Affects the symbol table code labels Feb 7, 2022
@oowekyala oowekyala added this to the 7.0.0 milestone Feb 7, 2022
oowekyala added a commit to oowekyala/pmd that referenced this issue Feb 7, 2022
@oowekyala
Fix pmd#3763 - ambiguity error
dff3458 
Problem was that the header scopes looked like this:

   IMPORTED -> EMPTY -> JAVA_LANG

Where IMPORTED and JAVA_LANG both can resolve the same
name NAME. The empty symtable is administrative, it's
a shadow barrier. With the previous definition of a
 shadow barrier, the barriers were positioned this way:

   IMPORTED -> EMPTY] -> JAVA_LANG]

IMPORTED asks for NAME and finds something. It's not
a shadow barrier so it asks EMPTY for NAME. EMPTY
does not know NAME so it asks its parent, ignoring that
it itself is a shadow barrier.

Now we don't call `ShadowChain::resolve` to collect
shadowed names to avoid this situation.
@oowekyala oowekyala mentioned this issue Feb 7, 2022
Merged
@adangel adangel linked a pull request Feb 18, 2022 that will close this issue
[java] Fix #3763 - ambiguity error #3764
Merged
adangel added a commit that referenced this issue Feb 18, 2022
@adangel
Merge pull request #3764 from oowekyala:issue3763-ambiguity-error
b9542e5 
[java] Fixes #3763 - ambiguity error #3764
@adangel adangel mentioned this issue Jan 23, 2023
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:bug PMD crashes or fails to analyse a file. in:symbol-table Affects the symbol table code
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

[java] Fix #3763 - ambiguity error oowekyala/pmd
1 participant
@oowekyala