Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] DontCallThreadRun can't detect the case that call run() in foo.bar.run() #2538

Closed
wuchiuwong opened this issue May 26, 2020 · 1 comment
Closed

[java] DontCallThreadRun can't detect the case that call run() in foo.bar.run() #2538

wuchiuwong opened this issue May 26, 2020 · 1 comment
Labels
a:false-negative PMD doesn't flag a problematic piece of code
Milestone
7.0.0

Comments

@wuchiuwong
Copy link

Affects PMD Version:
6.22.0
Rule:
DontCallThreadRun

Description:
DontCallThreadRun can't detect the case that call run() in foo.bar.run(). This rule is implemented through xpath search: This rule is implemented through xpath search:

//StatementExpression/PrimaryExpression
[
    PrimaryPrefix
    [
        ./Name[ends-with(@Image, '.run') or @Image = 'run']
        and substring-before(Name/@Image, '.') =//VariableDeclarator/VariableDeclaratorId/@Image
            [../../../Type/ReferenceType/ClassOrInterfaceType[pmd-java:typeIs('java.lang.Thread')]]
        or (./AllocationExpression/ClassOrInterfaceType[pmd-java:typeIs('java.lang.Thread')]
        and ../PrimarySuffix[@Image = 'run'])
    ]
]

AST analyse result of the code sample:

<PrimaryPrefix FindBoundary='false' Image='' SingleLine='true' SuperModifier='false' ThisModifier='false'>
	<Name FindBoundary='false' Image='client.blink.run' SingleLine='true' />
</PrimaryPrefix>
<PrimarySuffix ArgumentCount='0' Arguments='true' ArrayDereference='false' FindBoundary='false' Image='' SingleLine='true'>
	<Arguments ArgumentCount='0' FindBoundary='false' Image='' SingleLine='true' Size='0' />
</PrimarySuffix>

Possible error when detecting whether the type of client.blink is java.lang.Thread

Code Sample demonstrating the issue:

client.blink.run();

Expected outcome:
false-negative

Running PMD through:
CLI
@wuchiuwong wuchiuwong added the a:bug PMD crashes or fails to analyse a file. label May 26, 2020
@oowekyala oowekyala added a:false-negative PMD doesn't flag a problematic piece of code and removed a:bug PMD crashes or fails to analyse a file. labels Oct 26, 2020
@oowekyala oowekyala added this to the 7.0.0 milestone Nov 10, 2020
oowekyala added a commit to oowekyala/pmd that referenced this issue Nov 10, 2020
@oowekyala
Check fixes pmd#2538
5ac0c9f
@oowekyala oowekyala mentioned this issue Nov 11, 2020
Merged
5 tasks
@adangel
Copy link
Member

adangel commented Dec 11, 2020

Fixed via #2899 for PMD 7.

@adangel adangel closed this as completed Dec 11, 2020
@adangel adangel changed the title [java]DontCallThreadRun can't detect the case that call run() in foo.bar.run() [java] DontCallThreadRun can't detect the case that call run() in foo.bar.run() Jan 7, 2023
@adangel adangel mentioned this issue Jan 23, 2023
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:false-negative PMD doesn't flag a problematic piece of code
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
3 participants
@adangel @wuchiuwong @oowekyala