Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Allow abstract node types to be valid rulechain visits #1785

Closed
oowekyala opened this issue Apr 20, 2019 · 0 comments · Fixed by #2490
Closed

[core] Allow abstract node types to be valid rulechain visits #1785

oowekyala opened this issue Apr 20, 2019 · 0 comments · Fixed by #2490
Milestone
7.0.0

Comments

@oowekyala
Copy link
Member

oowekyala commented Apr 20, 2019 •
edited
Loading

Rulechain visits are for now entirely handled as strings:

pmd/pmd-core/src/main/java/net/sourceforge/pmd/lang/rule/AbstractRule.java

Line 44 in 4bb55e4

private List<String> ruleChainVisits = new ArrayList<>();

The implementation also throws an exception (!) if the node class doesn't have a hardcoded "AST" prefix:

pmd/pmd-core/src/main/java/net/sourceforge/pmd/lang/rule/AbstractRule.java

Lines 319 to 324 in 4bb55e4

public void addRuleChainVisit(Class<? extends Node> nodeClass) {
if (!nodeClass.getSimpleName().startsWith("AST")) {
throw new IllegalArgumentException("Node class does not start with 'AST' prefix: " + nodeClass);
}
addRuleChainVisit(nodeClass.getSimpleName().substring("AST".length()));
}

Introducing some abstractions into the AST (like done in #1759, argumented on the wiki) has a number of advantages, but the current rulechain implementation doesn't scale. Adding a rulechain visit to an abstract node type currently does nothing, instead of visiting all nodes having the specified supertype.

Refs #1772

There's the exact same problem with XPath queries, which I'll explain in another issue
This was referenced Apr 20, 2019
Merged
Open
@oowekyala oowekyala mentioned this issue May 18, 2020
Merged
6 tasks
@adangel adangel added this to the 7.0.0 milestone Jun 26, 2020
@adangel adangel linked a pull request Jun 26, 2020 that will close this issue
[core] Simplify the rulechain #2490
Merged
6 tasks
adangel added a commit that referenced this issue Jun 26, 2020
@adangel
[core] Simplify the rulechain #2490
cc0f7ad 
Merge branch 'pr-2490' into pmd/7.0.x

Fixes #1785
@adangel adangel closed this as completed Jun 26, 2020
@adangel adangel mentioned this issue Jan 23, 2023
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

[core] Simplify the rulechain oowekyala/pmd
2 participants
@adangel @oowekyala