Skip to content

Fix: Skip DNS setup if no zones exist in Azure resource group#730

Merged
maciaszczykm merged 1 commit intomainfrom
marcin/prod-4746-azure-failure-when-running-plain-plural-up
Apr 27, 2026
Merged

Fix: Skip DNS setup if no zones exist in Azure resource group#730
maciaszczykm merged 1 commit intomainfrom
marcin/prod-4746-azure-failure-when-running-plain-plural-up

Conversation

@maciaszczykm
Copy link
Copy Markdown
Member

@maciaszczykm maciaszczykm commented Apr 27, 2026

Summary

When running plural up with a new resource group, fetching DNS zones failed with a 404 because the group didn't exist yet (it's created later in the process). AzureDNSZones now returns an empty list instead of an error in this case, and askAppDomain silently skips the DNS zone prompt when there are no zones.

Test Plan

...

? Enter the name of your cluster: <redacted>
? Select the location you want to deploy to: polandcentral
? Select the resource group to use: Create new...
? Enter resource group name: <redacted>
? Select the storage account to use: Create new...
? Enter globally unique storage account name: <redacted>
? Enter a unique, memorable string to use for bucket naming, e.g. an abbreviation for your company: <redacted>
? Enter subdomain of onplural.sh domain that you want to use: <redacted>
? You're attempting to setup plural outside a git repository. Would you like us to set one up for you here? Yes
? Select the SCM provider to use for your repository: github

...

Finished setting up your management cluster!
Feel free to use terraform as you normally would, and leverage the gitops setup we've generated in the bootstrap/ subfolder

Process finished with the exit code 0

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@linear
Copy link
Copy Markdown

linear Bot commented Apr 27, 2026

@maciaszczykm maciaszczykm added the bug-fix This pull request fixes a bug label Apr 27, 2026
@maciaszczykm maciaszczykm marked this pull request as ready for review April 27, 2026 11:51
@maciaszczykm maciaszczykm merged commit c924810 into main Apr 27, 2026
14 of 15 checks passed
@maciaszczykm maciaszczykm deleted the marcin/prod-4746-azure-failure-when-running-plain-plural-up branch April 27, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix This pull request fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants