fix(up --dry-run): fix dry-run for plural up across all providers#729
Merged
michaeljguarino merged 1 commit intomainfrom Apr 30, 2026
Conversation
michaeljguarino
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily refactors several methods and functions to consistently use receiver variable names (
cinstead ofctxorcontext) across multiple files, which improves code readability and reduces confusion. Additionally, it introduces a standardized approach for handling dry-run mode in provider creation functions, ensuring that a project manifest is written appropriately when dry-run is enabled.Key changes include:
Refactoring for Consistency and Readability:
ctxorcontexttocacrosspkg/up/context.goandpkg/up/deploy.go, affecting methods likeidentifier,IgnorePreflights,SetImportCluster,Backfill,Deploy,Destroy, and related helpers.Dry-run Mode Enhancements:
mkAWS,mkAzure,mkBYOK, and GCP'sWithConfigoption) to create and write a minimalProjectManifestwhen dry-run is enabled. This ensures consistent behavior for all providers in dry-run scenarios.Bug Fixes and Minor Improvements:
HandleInitWithProjectso theprojectvariable is set directly, avoiding shadowing and improving error handling.handleUpandHandleInitWithProjectto use local variables (cloud,dryRun) for clarity and correctness.Labels
Test Plan
Locally w/
plural up --dry-runfor all providers. The only prerequisite was configuring the Git repository.Checklist