chore: remove unused taggers field (GoogleContainerTools#9513)

cuishuang · web-flow · commit 264e2744e50c · 2024-11-11T15:43:34.000-05:00
Signed-off-by: cuishuang &lt;imcusg@gmail.com&gt;
diff --git a/pkg/skaffold/tag/tagger_mux.go b/pkg/skaffold/tag/tagger_mux.go
@@ -26,7 +26,6 @@ import (
 )
 
 type TaggerMux struct {
-	taggers     []Tagger
 	byImageName map[string]Tagger
 }
 
@@ -41,18 +40,16 @@ func (t *TaggerMux) GenerateTag(ctx context.Context, image latest.Artifact) (str
 func NewTaggerMux(runCtx *runcontext.RunContext) (Tagger, error) {
 	pipelines := runCtx.GetPipelines()
 	m := make(map[string]Tagger)
-	sl := make([]Tagger, len(pipelines))
 	for _, p := range pipelines {
 		t, err := getTagger(runCtx, &p.Build.TagPolicy)
 		if err != nil {
 			return nil, fmt.Errorf("creating tagger: %w", err)
 		}
-		sl = append(sl, t)
 		for _, a := range p.Build.Artifacts {
 			m[a.ImageName] = t
 		}
 	}
-	return &TaggerMux{taggers: sl, byImageName: m}, nil
+	return &TaggerMux{byImageName: m}, nil
 }
 
 func getTagger(runCtx *runcontext.RunContext, t *latest.TagPolicy) (Tagger, error) {

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,6 @@ import (`
`26`	`26`	`)`
`27`	`27`
`28`	`28`	`type TaggerMux struct {`
`29`		`- taggers []Tagger`
`30`	`29`	`byImageName map[string]Tagger`
`31`	`30`	`}`
`32`	`31`
`@@ -41,18 +40,16 @@ func (t *TaggerMux) GenerateTag(ctx context.Context, image latest.Artifact) (str`
`41`	`40`	`func NewTaggerMux(runCtx *runcontext.RunContext) (Tagger, error) {`
`42`	`41`	`pipelines := runCtx.GetPipelines()`
`43`	`42`	`m := make(map[string]Tagger)`
`44`		`- sl := make([]Tagger, len(pipelines))`
`45`	`43`	`for _, p := range pipelines {`
`46`	`44`	`t, err := getTagger(runCtx, &p.Build.TagPolicy)`
`47`	`45`	`if err != nil {`
`48`	`46`	`return nil, fmt.Errorf("creating tagger: %w", err)`
`49`	`47`	`}`
`50`		`- sl = append(sl, t)`
`51`	`48`	`for _, a := range p.Build.Artifacts {`
`52`	`49`	`m[a.ImageName] = t`
`53`	`50`	`}`
`54`	`51`	`}`
`55`		`- return &TaggerMux{taggers: sl, byImageName: m}, nil`
	`52`	`+ return &TaggerMux{byImageName: m}, nil`
`56`	`53`	`}`
`57`	`54`
`58`	`55`	`func getTagger(runCtx runcontext.RunContext, t latest.TagPolicy) (Tagger, error) {`