Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next version of babashka will be able to support schema with these changes.
The main thing to note here is that babashka cannot dynamically create classes (since it runs on graalvm), so
cc/fn,cc/defrecord,cc/defprotocolhave very different implementations than JVM Clojure.Here, it mostly amounts to broadening
class?checks to also account forsci.lang.Type, which is babashka's representation of dynamically generated classes.We also use fn identity for
s/fn-schemasince bb keeps a pool of its ownfnclasses for each arity, and revert to less optimized CLJS approach in some other places.Note: in bb, both
:cljand:bbreader conditionals are active.Note: in
schema.macros, we can't use reader conditionals (.clj) soif-bbuses system props to determine platform.Note: bb doesn't support extending
print-methodvia a protocol, somacros/defrecord-schemais used to extend it for each schema primitive.Bonus: adds pretty
pr-strprinting in CLJS.The entire test suite remarkably runs in 0.5 seconds: