Exclude sitemap.xml from caching #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Serving the correct content types would be a more elegant solution to the actual problem. There’s no reason not to cache sitemaps or feeds in general. This might be achieved via webserver config for static HDD cache, derived from the request URI. Well, possible, but not elegant. But since Cachify has no logic for non-HTML content and the clearing mechanisms would have to be adjusted to properly invalidate the sitemap cache, exclusion seems reasonable at this point. |
stklcode
approved these changes
Jan 7, 2022
krafit
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #242.
The PR checks for the new sitemap feature added in WP 5.5, thanks @ManuelHu for the query var checks in the issue and @chesio for the tip with
get_query_var().