Fix script tag for notebook renderers #5154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Not my area but I have no objection if this fixes the issue and doesn't break anything else |
Collaborator
Author
|
Also this has been tested by someone who was encountering this issue and it works! #4953 (comment) |
alexcjohnson
approved these changes
Apr 25, 2025
Collaborator
alexcjohnson
left a comment
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Makes sense to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
notebookrenderer to use a plain script tag when embedding all of plotly.js rather than using<script type="module">. This fixes #4953. For more context on JS modules, see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules.Some context:
<script type="module">was added in Use modernnative ES6 importto load plotly.js bundle instead ofrequirejswhich is no longer under active development #4763.<script type="text/javascript">: https://github.com/plotly/plotly.py/blame/26c4443b1a2efc83a5af3efd179c68f5e13cdfad/packages/python/plotly/plotly/io/_base_renderers.py#L292. It seems like usingtype="text/javascript"is no longer necessary since HTML 5: https://stackoverflow.com/questions/25737619/what-is-the-difference-between-script-type-text-javascript-and-script.