I think only integers are supported - there's an electron bug with floats: electron/electron#9361 (comment)

In my investigations, I noticed that the pageSize specified in the request body is not being passed to printToPDF call. This fixes the issue.

I think only integers are supported - there's an electron bug with floats:electron/electron#9361 (comment)

We can Math.ceil the incoming values to ensure only integers are passed along. Choosing b/w Math.ceil or Math.floor or Math.round does not matter because it will only change by +- 1 micron.

@antoinerg or @etpinard Please review.. I have checked this in an on-prem environment and custom page sizes work for me.

@tarzzz Don't we want this for 3.2-release?

Looks good to me 💃

That said, are folks ok with providing the page size in microns? Maybe we could change it to pixels, call this a breaking change and bump orca to v2?

are folks ok with providing the page size in microns

It is not a breaking change as the pageSize has always been in microns in the API.

Correct @tarzzz your PR here does not introduce a breaking change.

But what if we'd like to improve the API (here OR in a future PR), I think making users input page dimensions in pixels would be beneficial.

But what if we'd like to improve the API (here OR in a future PR), I think making users input page dimensions in pixels would be beneficial.

Yes, but this is going to be the part of a maintenance release.. so we should not be introducing breaking change(s) or new features.

If required, We can add the new issue (for dimensions in pixels) as the part of the next release work.

@tarzzz thanks again for taking on this issue. Could you also make a PR to merge those changes into master?