Skip to content

Fix --output orca graph CLI option for path/to/filename #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
etpinard merged 2 commits into from
Jan 2, 2019
Merged

Fix --output orca graph CLI option for path/to/filename #176

etpinard merged 2 commits into from
Jan 2, 2019

Conversation

@etpinard
Copy link
Contributor

@etpinard etpinard commented Dec 28, 2018

fixes #101 and adds a bunch more orca --graph tests

cc @antoinerg

@etpinard
Copy link
Contributor Author

etpinard commented Dec 28, 2018 •
edited
Loading

Argg. Something is wrong again with docker-build-and-push:

image

EDIT: passed after 4 retries.

@etpinard etpinard added this to the v1.2.0 milestone Dec 29, 2018
@antoinerg
Copy link
Collaborator

antoinerg commented Jan 2, 2019

Thank you @etpinard for the fix! 💃

@etpinard etpinard merged commit 14de6f5 into master Jan 2, 2019
@etpinard etpinard deleted the fix-output-path-resolve branch January 2, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: reviewable type: bug

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

orca() does not support file paths

3 participants

@etpinard @antoinerg