add support for CORS #135
Merged
add support for CORS #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Very cool. Two comments:
|
Collaborator
Author
|
@etpinard I have never seen CORS enabled by default in any HTTP service since it can be a security risk. I think I would leave it off in case we manage sensitive information in Orca down the road. |
Contributor
|
Beautiful. 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
--corsoption to enable Cross-Origin Resource Sharing (CORS).This may be out of scope for Orca since it can be handled at the HTTP layer by a downstream server but it was also very simple to add here.