Skip to content

Fix fast reader tests and warnings for "win32" - #6

Closed
dhomeier wants to merge 2 commits into
pllim:no-more-np-asfarrayfrom
dhomeier:pllim-no-more-np-asfarray
Closed

dhomeier wants to merge 2 commits into
pllim:no-more-np-asfarrayfrom
dhomeier:pllim-no-more-np-asfarray

Conversation

@dhomeier

Copy link
Copy Markdown

Description

Fixes some issues found in astropy#15235 (comment)

  1. The "win32" job uses a 64 bit compiler and as such passes the double precision test, just shows somewhat deviant behaviour on warnings.
  2. A construct such as https://github.com/astropy/astropy/blob/53188c39a23c33b72df5850ec59e31886f84e29d/astropy/io/ascii/tests/test_c_reader.py#L1401-L1410
    would have never worked for 0 warnings, as pytest.warns() already raises an error in that case (fixed with pytest.warns(Warning)).

@dhomeier
dhomeier force-pushed the pllim-no-more-np-asfarray branch from e5d960d to dfdc3da Compare August 29, 2023 13:58
@dhomeier dhomeier closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants