[2.4.x] 204/304 response should also trigger onDoneEnumerating for the body #7004
Conversation
|
Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
|
Signed the CLA. |
|
May I ask what is the equivalent of the body Enumerator's onDoneEnumerating hook in 2.6.x? I want to verify whether the 2.6.x version has the same issue. Thanks! |
FranklinYinanDing
changed the title
|
Bump! Please review! |
|
@FranklinYinanDing, this looks good to me. I've submitted two other pull requests against branch 2.4.x to fix other small problems: #7048 and #7039. They were already merged. Do you mind rebasing your branch against the most 2.4.x again so that we can see if the build is more stable after these changes? |
|
@marcospereira Done! Thank you! |
|
Thank you, @FranklinYinanDing! |
|
@marcospereira May I ask what is the equivalent of the body Enumerator's onDoneEnumerating hook in 2.6.x? I want to verify whether the 2.6.x version has the same issue. Thanks! |
3 participants
Fixes the issue of "204/304 response didn't trigger onDoneEnumerating for the body", which @bbarkley has reported.
When the response status is 204 or 304, the response doesn't send out with a body. The case of StreamWithNoBody in both Netty server and Akka HTTP server didn't consume the response's empty Enumerator body, thus the onDoneEnumerating hook couldn't be triggered.
Added tests, which fail without the fix.
Create this pull request on behalf of @bbarkley.