Skip to content

Conversation

@richdougherty
Copy link
Member

This is a backport of #6153 from master. The 2.5.x backport is #6210.

Fairly extensive changes were required to backport to 2.4.x.

This is a backport of playframework#6153.

When the backend server (Netty, Akka HTTP) discovers an error in a
result (e.g. invalid headers) the server needs to abort processing the
result and send an error result to the user. Previously, this error
handling was done with custom error handling code for the server.

This pull request changes the server behavior to use the application's
HttpErrorHandler to generate the error result instead of generating a
custom error response. Using the existing error handler makes the
error handling more standardized. It also means that the application
will be notified when an error occurs during result generation, which
will make it easier to track errors that occur in Play applications
(see playframework#6098, playframework#6099).
@richdougherty richdougherty changed the title Result error handling 2.4.x Better Result error handling (2.4.x) Jun 8, 2016
@gmethvin gmethvin merged commit 6df01f3 into playframework:2.4.x Jun 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants