Declare Java 25 LTS officially supported (backport #13499) by @mkurz #13501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Cherry-pick of 919d027 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
mkurz
changed the title
mkurz
changed the title
(cherry picked from commit 919d027) # Conflicts: # dev-mode/sbt-plugin/src/main/scala/play/sbt/PlaySettings.scala
mkurz
force-pushed
the
mergify/bp/main/pr-13499
branch
from
254b400 to
5189acd
Compare
Member
|
Merging even though Gradle still not ready yet, but will be eventually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests pass with Java 25 final release candiate:
IMHO there is no reason why not declare it as supported.
History shows that the final RC of a Java release usually becomes the final release:
There are not P1 bugs reported yet: https://bugs.openjdk.org/issues/?filter=33410
Therefore it's very very likely to say nothing relevant will change anymore that would influence Play's support for Java 25 until its final release in 2 weeks from today.
Regarding Scala:
They will upgrad ASM in all of their next releases so they officially declarse Java 25 support as well:
For Play this is not relevant as it seems, but end users likely want to upgrade to that latest Scala versions when they are out.
This is an automatic backport of pull request #13499 done by Mergify.