Skip to content

fix routes cache directory #13443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkurz merged 1 commit into from
Aug 21, 2025
Merged

fix routes cache directory #13443

mkurz merged 1 commit into from
Aug 21, 2025

Conversation

@xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Aug 4, 2025

Pull Request Checklist

Helpful things

Fixes

fix cache directory location. don't use target/scala-2.13/routes/ sources if Scala 3.

Purpose

see scripted test. following error if without this fix

[info] [error] java.lang.AssertionError: assertion failed: scalaVersion = 3.7.2, file = /private/var/folders/nz/vb2z3s8j7719gg71zgz9gj_40000gn/T/sbt_c167a6a1/target/scala-2.13/routes/main/controllers/routes.java
[info] [error] 	at scala.Predef$.assert(Predef.scala:223)
[info] [error] 	at $ef7a6fd61184684303de$.$anonfun$$sbtdef$2(/private/var/folders/nz/vb2z3s8j7719gg71zgz9gj_40000gn/T/sbt_c167a6a1/build.sbt:14)
[info] [error] 	at $ef7a6fd61184684303de$.$anonfun$$sbtdef$2$adapted(/private/var/folders/nz/vb2z3s8j7719gg71zgz9gj_40000gn/T/sbt_c167a6a1/build.sbt:13)
[info] [error] 	at scala.collection.immutable.List.foreach(List.scala:431)
[info] [error] 	at $ef7a6fd61184684303de$.$anonfun$$sbtdef$1(/private/var/folders/nz/vb2z3s8j7719gg71zgz9gj_40000gn/T/sbt_c167a6a1/build.sbt:13)
[info] [error] 	at $ef7a6fd61184684303de$.$anonfun$$sbtdef$1$adapted(/private/var/folders/nz/vb2z3s8j7719gg71zgz9gj_40000gn/T/sbt_c167a6a1/build.sbt:11)

Background Context

References

@xuwei-k xuwei-k marked this pull request as ready for review August 4, 2025 03:12
@mkurz mkurz merged commit 8203ce3 into playframework:main Aug 21, 2025
29 checks passed
@mkurz
Copy link
Member

mkurz commented Aug 21, 2025

@Mergifyio backport 2.9.x 3.0.x

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2025 •
edited
Loading

backport 2.9.x 3.0.x

✅ Backports have been created

Details

This was referenced Aug 21, 2025
Merged
Merged
mergify bot added a commit that referenced this pull request Aug 21, 2025
@mergify
Merge pull request #13462 from playframework/mergify/bp/3.0.x/pr-13443
7ba3c40 
[3.0.x] fix routes cache directory (backport #13443) by @xuwei-k
mergify bot added a commit that referenced this pull request Aug 22, 2025
@mergify
Merge pull request #13461 from playframework/mergify/bp/2.9.x/pr-13443
4a93004 
[2.9.x] fix routes cache directory (backport #13443) by @xuwei-k
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xuwei-k @mkurz