A call to onClientError from the server backend was missing the HttpErrorInfo attr
#13416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@Mergifyio backport 2.9.x 3.0.x |
Contributor
✅ Backports have been createdDetails
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changed code is part of the
resultConversionWithErrorHandlingmethod. Obviously that code lives intransport/server/and is part of the backend servers and only gets called byNettyModelConversionPekkoModelConversionWhen calling
onServerErrorfrom one of the backends we alway add a"server-backend"HttpErrorInfoattr:playframework/transport/server/play-netty-server/src/main/scala/play/core/server/netty/PlayRequestHandler.scala
Line 118 in 6a4473c
playframework/transport/server/play-pekko-http-server/src/main/scala/play/core/server/PekkoHttpServer.scala
Line 342 in 6a4473c
playframework/transport/server/play-pekko-http-server/src/main/scala/play/core/server/PekkoHttpServer.scala
Line 477 in 6a4473c
Seems like I missed this one 😢
Introduced in