fix "match may not be exhaustive" warning

xuwei-k · xuwei-k · commit 8cab69753d86 · 2025-08-03T15:23:14.000+09:00
diff --git a/dev-mode/play-routes-compiler/src/main/twirl/play/routes/compiler/static/reverseRouter.scala.twirl b/dev-mode/play-routes-compiler/src/main/twirl/play/routes/compiler/static/reverseRouter.scala.twirl
@@ -30,7 +30,7 @@ import @if(!i.startsWith("_root_.")){_root_.}@i}
     @markLines(routes: _*)
     def @(method)@(reverseSignature(routes)): Call = @ob
     @defining(reverseParameters(routes)) { params =>
-      (@reverseMatchParameters(params, true)) match @ob
+      ((@reverseMatchParameters(params, false)): @@unchecked) match @ob
       @reverseUniqueConstraints(routes, params) { (route, parameters, parameterConstraints, localNames) =>
         @markLines(route)
         case (@parameters) @parameterConstraints =>
diff --git a/dev-mode/sbt-plugin/src/sbt-test/play-sbt-plugin/routes-compiler-exhaustive-warning/build.sbt b/dev-mode/sbt-plugin/src/sbt-test/play-sbt-plugin/routes-compiler-exhaustive-warning/build.sbt
@@ -0,0 +1,11 @@
+// Copyright (C) from 2022 The Play Framework Contributors <https://github.com/playframework>, 2011-2021 Lightbend Inc. <https://www.lightbend.com>
+
+enablePlugins(PlayScala)
+
+def Scala3 = "3.7.2"
+
+scalaVersion := Scala3
+
+crossScalaVersions := Seq("2.13.16", Scala3)
+
+scalacOptions += "-Werror"
diff --git a/dev-mode/sbt-plugin/src/sbt-test/play-sbt-plugin/routes-compiler-exhaustive-warning/conf/routes b/dev-mode/sbt-plugin/src/sbt-test/play-sbt-plugin/routes-compiler-exhaustive-warning/conf/routes
@@ -0,0 +1,5 @@
+# Copyright (C) from 2022 The Play Framework Contributors <https://github.com/playframework>, 2011-2021 Lightbend Inc. <https://www.lightbend.com>
+
+GET  /aaa/*file  controllers.Assets.versioned(path="/public/aaa", file: Asset)
+
+GET  /bbb/*file  controllers.Assets.versioned(path="/public/bbb", file: Asset)
diff --git a/dev-mode/sbt-plugin/src/sbt-test/play-sbt-plugin/routes-compiler-exhaustive-warning/project/plugins.sbt b/dev-mode/sbt-plugin/src/sbt-test/play-sbt-plugin/routes-compiler-exhaustive-warning/project/plugins.sbt
@@ -0,0 +1,3 @@
+// Copyright (C) from 2022 The Play Framework Contributors <https://github.com/playframework>, 2011-2021 Lightbend Inc. <https://www.lightbend.com>
+
+addSbtPlugin("org.playframework" % "sbt-plugin" % sys.props("project.version"))
diff --git a/dev-mode/sbt-plugin/src/sbt-test/play-sbt-plugin/routes-compiler-exhaustive-warning/test b/dev-mode/sbt-plugin/src/sbt-test/play-sbt-plugin/routes-compiler-exhaustive-warning/test
@@ -0,0 +1 @@
+> + compile

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+// Copyright (C) from 2022 The Play Framework Contributors <https://github.com/playframework>, 2011-2021 Lightbend Inc. <https://www.lightbend.com>`
	`2`	`+`
	`3`	`+addSbtPlugin("org.playframework" % "sbt-plugin" % sys.props("project.version"))`