Allow Sessions to support secure cookie settings#211
Merged
ringabout merged 1 commit intoplanety:develfrom Feb 24, 2023
Merged
Conversation
Signed-off-by: Jacob Torrey <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have built a small web-app based on Prologue that is integrated with a legacy site in an iframe. The iframe "drops" the sessions since the sameSite is set to Lax, and if it's set to None, the secure flag must be set as well, which is impossible without exposing that parameter to the session init caller.
Running with these changes and an associated modification to the cookiejar package allows the web application to function as expected within an iframe.