Skip to content

Use patch for ARM64 assembly bitmap extraction#81

Merged
tschaub merged 1 commit intomainfrom
null-panic
Oct 2, 2023
Merged

Use patch for ARM64 assembly bitmap extraction#81
tschaub merged 1 commit intomainfrom
null-panic

Conversation

@tschaub
Copy link
Copy Markdown
Member

@tschaub tschaub commented Oct 2, 2023

This temporarily replaces the Arrow dependency with the fix in apache/arrow#37785 - making it possible to read Parquet files with all null values on ARM64 devices.

Fixes #57.

@zeroshade
Copy link
Copy Markdown

@tschaub If desired, instead of using that patch (until it is merged) you could also just build with the noasm tag which should fix the issue until the fix is merged in. The noasm tag will just force it to default to the pure go implementation rather than use the vectorized assembly which has the issue.

@tschaub
Copy link
Copy Markdown
Member Author

tschaub commented Oct 2, 2023

Thanks, @zeroshade. I figured this could be an opportunity to help validate the fix too. If it doesn't get merged or if other issues come up, I'll go with the noasm tag.

@tschaub tschaub merged commit 6e08eca into main Oct 2, 2023
@tschaub tschaub deleted the null-panic branch October 2, 2023 17:15
@tschaub tschaub mentioned this pull request Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Overture parquet conversion to GeoParquet

2 participants