Merged
Conversation
Member
|
Thanks for the contribution, @felix-schott! I pushed an additional commit that tweaks the extension matching and adds a test with unexpected newline-delimited data. You can try it out in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @tschaub & @cholmes,
I think this PR should solve the issue addressed in #202 - I don't have access to the Planet API, so couldn't test with the command you provided but the code changes work for generic new-line delimited GeoJSON, so I don't see a reason why it wouldn't work in your case as well.
@tschaub, please let me know if you see any shortcomings in the PR or think it requires more rigorous testing.
Thanks
Felix