A number of fixes + win32 compat#1
Merged
kaniini merged 7 commits intopkgconf:masterfrom May 2, 2012
mgorny:master
Merged
Conversation
This is what pkg-config does, and it is necessary because ':' is part of path specification on win32.
Instead of repeating the parsing stage after reaching the null terminator, just handle it inside the loop and terminate the loop afterwards.
We always replace that current pos with a null terminator, so it doesn't matter what follows it.
This avoids looking for '/foo.pc'.
Contributor
Author
|
And also a few fixes and path lookup optimizations. |
That condition is now handled within pkg_find() completely.
PKG_CONFIG_PATH paths must take precedence over the default path. Otherwise, we would be unable to override default .pc files. And while I'm at it, simplify the whole code. It is pointless to introduce another buffer and a lot of string mangling for one additional path.
kaniini
added a commit
that referenced
this pull request
May 2, 2012
A number of fixes + win32 compat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifying code and making it more compatible with pkg-config.