Copyedit the package documentation#135
Merged
davecheney merged 1 commit intopkg:masterfrom Oct 8, 2018
Merged
Conversation
Remove spurious words, add missing words, and smooth out a few sentences.
|
Just trying to help out by cleaning up :-) Can this be merged? |
Member
|
Thank you very much. |
| // | ||
| // can be inspected by errors.Cause. errors.Cause will recursively retrieve | ||
| // the topmost error which does not implement causer, which is assumed to be | ||
| // the topmost error that does not implement causer, which is assumed to be |
There was a problem hiding this comment.
Would which be more formal than that when you want to start an object clause?
Contributor
Author
There was a problem hiding this comment.
I don't know about more formal, but it doesn't sound correct to me. In this case, that introduces a defining clause, without which the sentence would possibly make sense but be incorrect: we don't merely retrieve the topmost error; we retrieve the topmost that exhibits this particular characteristic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove spurious words, add missing words, and smooth out a few sentences.
I didn't edit any of the function- or type-level documentation in this pass.